Add filter to GetMinUnfinishedWatermark query#34965
Add filter to GetMinUnfinishedWatermark query#34965changliiu wants to merge 2 commits intoapache:masterfrom
Conversation
6dd1c39 to
e77b86a
Compare
f5020d9 to
65aa1eb
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
2deda7c to
7cc7fcc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34965 +/- ##
=============================================
+ Coverage 54.50% 68.65% +14.15%
Complexity 1479 1479
=============================================
Files 1012 194 -818
Lines 160667 8111 -152556
Branches 1079 1079
=============================================
- Hits 87573 5569 -82004
+ Misses 70991 2158 -68833
+ Partials 2103 384 -1719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
|
|
waiting on author (PR is still in draft state) |
To improve the performance of the query for GetUnfinishedMinWatermark, we can add a filter to the query.
Note that the query run on a cache to refresh every 1s. We can remember the cached value every time and use the value as a filter in the next time query.